Skip to content

gh-146197: Include a bit more information in sys._emscripten_info.runtime#146346

Merged
vstinner merged 1 commit intopython:mainfrom
hoodmane:emscripten-info-runtime
Mar 23, 2026
Merged

gh-146197: Include a bit more information in sys._emscripten_info.runtime#146346
vstinner merged 1 commit intopython:mainfrom
hoodmane:emscripten-info-runtime

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Mar 23, 2026

Before: sys._emscripten_info.runtime is Node.js/24, now it says node v24.14.0 (v8 13.6.233.17-node.41). I also added detection for node and bun.

@vstinner
Copy link
Member

pythoninfo of the Emscripten CI job says:

sys._emscripten_info: sys._emscripten_info(emscripten_version=(4, 0, 12), runtime='node v24.14.0 (v8 13.6.233.17-node.41)', pthreads=False, shared_memory=False)

needs backport to 3.14

I'm not sure that it's a good idea to change sys._emscripten_info.runtime in a Python 3.14.x bugfix release. Some projects may rely on the current string format.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it may safer to not backport the change to 3.14.

@hoodmane
Copy link
Contributor Author

Right, I suppose we don't need the backport for anything.

@hoodmane hoodmane removed the needs backport to 3.14 bugs and security fixes label Mar 23, 2026
@vstinner vstinner enabled auto-merge (squash) March 23, 2026 21:50
@vstinner vstinner merged commit 7dc2f52 into python:main Mar 23, 2026
63 checks passed
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 24, 2026
…on into fix-pythongh-138577

* 'fix-pythongh-138577' of github.com:CuriousLearner/cpython:
  pythongh-146202: Create tmp_dir in regrtest worker (python#146347)
  pythongh-144319: obtain SeLockMemoryPrivilege on Windows (python#144928)
  pythongh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails (python#146200)
  pythongh-146197: Include a bit more information in sys._emscripten_info.runtime (python#146346)
  pythongh-135871: Reload lock internal state while spinning in `PyMutex_LockTimed` (pythongh-146064)
  pythongh-145719: Add `.efi` file detection in `mimetypes` (python#145720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants